fix(bugfix-workflow): add completeness guidance to prevent incomplete fixes#51
Draft
ambient-code[bot] wants to merge 1 commit intomainfrom
Draft
fix(bugfix-workflow): add completeness guidance to prevent incomplete fixes#51ambient-code[bot] wants to merge 1 commit intomainfrom
ambient-code[bot] wants to merge 1 commit intomainfrom
Conversation
… fixes Addresses feedback from session-1771963475 where the agent implemented polling logic but missed: - Complete list of terminal session phases (Error was omitted) - Interaction between keepPreviousData and polling - Verification of pattern documentation completeness Changes: - Add "Step 3.5: Verify Completeness" to fix skill with guidance on: * Identifying all possible states/phases/conditions * Understanding feature interactions * Verifying complete enumeration * Checking pattern documentation but verifying against codebase - Add state space enumeration to diagnose skill's impact assessment - Add completeness principle to CLAUDE.md - Add guidance to test all states/phases and feature interactions These changes promote thoroughness when implementing fixes involving state-dependent logic or interacting features. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds thoroughness and completeness guidance to the bugfix workflow to prevent incomplete implementations when fixing bugs involving state-dependent logic or interacting features.
Context
Based on 3 corrections from session-1771963475 where the agent implemented React Query polling logic but:
placeholderData: keepPreviousDatainteracts with pollingAll three corrections were marked as "incomplete" - the agent missed things that should have been done.
Changes
1. Fix Skill (
workflows/bugfix/.claude/skills/fix/SKILL.md)2. Diagnose Skill (
workflows/bugfix/.claude/skills/diagnose/SKILL.md)3. Test Skill (
workflows/bugfix/.claude/skills/test/SKILL.md)4. Principles (
workflows/bugfix/CLAUDE.md)Impact
These changes should prevent similar incomplete implementations by:
Testing
The changes are documentation updates to workflow guidance files. No code changes to test.
Session
https://app.ambient.dev/projects/ambient-platform-and-workflow-feedback-loop-running/sessions/session-1772032273